diff options
Diffstat (limited to 'src-tauri/src')
| -rw-r--r-- | src-tauri/src/core/fabric.rs | 27 | ||||
| -rw-r--r-- | src-tauri/src/core/forge.rs | 302 | ||||
| -rw-r--r-- | src-tauri/src/main.rs | 449 |
3 files changed, 715 insertions, 63 deletions
diff --git a/src-tauri/src/core/fabric.rs b/src-tauri/src/core/fabric.rs index fd38f41..3e4d50d 100644 --- a/src-tauri/src/core/fabric.rs +++ b/src-tauri/src/core/fabric.rs @@ -63,10 +63,31 @@ pub struct FabricLibrary { } /// Main class configuration for Fabric. +/// Can be either a struct with client/server fields or a simple string. #[derive(Debug, Deserialize, Serialize, Clone)] -pub struct FabricMainClass { - pub client: String, - pub server: String, +#[serde(untagged)] +pub enum FabricMainClass { + Structured { + client: String, + server: String, + }, + Simple(String), +} + +impl FabricMainClass { + pub fn client(&self) -> &str { + match self { + FabricMainClass::Structured { client, .. } => client, + FabricMainClass::Simple(s) => s, + } + } + + pub fn server(&self) -> &str { + match self { + FabricMainClass::Structured { server, .. } => server, + FabricMainClass::Simple(s) => s, + } + } } /// Represents a Minecraft version supported by Fabric. diff --git a/src-tauri/src/core/forge.rs b/src-tauri/src/core/forge.rs index 0f17bcc..e69b296 100644 --- a/src-tauri/src/core/forge.rs +++ b/src-tauri/src/core/forge.rs @@ -5,8 +5,7 @@ //! - Install Forge loader for a specific Minecraft version //! //! Note: Forge installation is more complex than Fabric, especially for versions 1.13+. -//! This implementation focuses on the basic JSON generation approach. -//! For full Forge 1.13+ support, processor execution would need to be implemented. +//! This implementation fetches the installer manifest to get the correct library list. use serde::{Deserialize, Serialize}; use std::error::Error; @@ -42,6 +41,46 @@ pub struct InstalledForgeVersion { pub path: PathBuf, } +/// Forge installer manifest structure (from version.json inside installer JAR) +#[derive(Debug, Deserialize)] +struct ForgeInstallerManifest { + id: Option<String>, + #[serde(rename = "inheritsFrom")] + inherits_from: Option<String>, + #[serde(rename = "mainClass")] + main_class: Option<String>, + #[serde(default)] + libraries: Vec<ForgeLibrary>, + arguments: Option<ForgeArguments>, +} + +#[derive(Debug, Deserialize)] +struct ForgeArguments { + game: Option<Vec<serde_json::Value>>, + jvm: Option<Vec<serde_json::Value>>, +} + +#[derive(Debug, Deserialize, Clone)] +struct ForgeLibrary { + name: String, + #[serde(default)] + downloads: Option<ForgeLibraryDownloads>, + #[serde(default)] + url: Option<String>, +} + +#[derive(Debug, Deserialize, Clone)] +struct ForgeLibraryDownloads { + artifact: Option<ForgeArtifact>, +} + +#[derive(Debug, Deserialize, Clone)] +struct ForgeArtifact { + path: Option<String>, + url: Option<String>, + sha1: Option<String>, +} + /// Fetch all Minecraft versions supported by Forge. /// /// # Returns @@ -138,18 +177,49 @@ pub fn generate_version_id(game_version: &str, forge_version: &str) -> String { format!("{}-forge-{}", game_version, forge_version) } +/// Fetch the Forge installer manifest to get the library list +async fn fetch_forge_installer_manifest( + game_version: &str, + forge_version: &str, +) -> Result<ForgeInstallerManifest, Box<dyn Error + Send + Sync>> { + let forge_full = format!("{}-{}", game_version, forge_version); + + // Download the installer JAR to extract version.json + let installer_url = format!( + "{}net/minecraftforge/forge/{}/forge-{}-installer.jar", + FORGE_MAVEN_URL, forge_full, forge_full + ); + + println!("Fetching Forge installer from: {}", installer_url); + + let response = reqwest::get(&installer_url).await?; + if !response.status().is_success() { + return Err(format!("Failed to download Forge installer: {}", response.status()).into()); + } + + let bytes = response.bytes().await?; + + // Extract version.json from the JAR (which is a ZIP file) + let cursor = std::io::Cursor::new(bytes.as_ref()); + let mut archive = zip::ZipArchive::new(cursor)?; + + // Look for version.json in the archive + let version_json = archive.by_name("version.json")?; + let manifest: ForgeInstallerManifest = serde_json::from_reader(version_json)?; + + Ok(manifest) +} + /// Install Forge for a specific Minecraft version. /// -/// Note: This creates a basic version JSON. For Forge 1.13+, the full installation -/// requires running the Forge installer processors, which is not yet implemented. -/// This basic implementation works for legacy Forge versions (<1.13) and creates -/// the structure needed for modern Forge (libraries will need to be downloaded -/// separately). +/// This function downloads the Forge installer JAR and runs it in headless mode +/// to properly install Forge with all necessary patches. /// /// # Arguments /// * `game_dir` - The .minecraft directory path /// * `game_version` - The Minecraft version (e.g., "1.20.4") /// * `forge_version` - The Forge version (e.g., "49.0.38") +/// * `java_path` - Path to the Java executable /// /// # Returns /// Information about the installed version. @@ -160,10 +230,11 @@ pub async fn install_forge( ) -> Result<InstalledForgeVersion, Box<dyn Error + Send + Sync>> { let version_id = generate_version_id(game_version, forge_version); - // Create basic version JSON structure - // Note: This is a simplified version. Full Forge installation requires - // downloading the installer and running processors. - let version_json = create_forge_version_json(game_version, forge_version)?; + // Fetch the installer manifest to get the complete version.json + let manifest = fetch_forge_installer_manifest(game_version, forge_version).await?; + + // Create version JSON from the manifest + let version_json = create_forge_version_json_from_manifest(game_version, forge_version, &manifest)?; // Create the version directory let version_dir = game_dir.join("versions").join(&version_id); @@ -182,55 +253,185 @@ pub async fn install_forge( }) } -/// Create a basic Forge version JSON. +/// Install Forge using the official installer JAR. +/// This runs the Forge installer in headless mode to properly patch the client. +/// +/// # Arguments +/// * `game_dir` - The .minecraft directory path +/// * `game_version` - The Minecraft version +/// * `forge_version` - The Forge version +/// * `java_path` - Path to the Java executable /// -/// This creates a minimal version JSON that inherits from vanilla and adds -/// the Forge libraries. For full functionality with Forge 1.13+, the installer -/// would need to be run to patch the game. +/// # Returns +/// Result indicating success or failure +pub async fn run_forge_installer( + game_dir: &PathBuf, + game_version: &str, + forge_version: &str, + java_path: &PathBuf, +) -> Result<(), Box<dyn Error + Send + Sync>> { + // Download the installer JAR + let installer_url = format!( + "{}net/minecraftforge/forge/{}-{}/forge-{}-{}-installer.jar", + FORGE_MAVEN_URL, game_version, forge_version, game_version, forge_version + ); + + let installer_path = game_dir.join("forge-installer.jar"); + + // Download installer + let client = reqwest::Client::new(); + let response = client.get(&installer_url).send().await?; + + if !response.status().is_success() { + return Err(format!("Failed to download Forge installer: {}", response.status()).into()); + } + + let bytes = response.bytes().await?; + tokio::fs::write(&installer_path, &bytes).await?; + + // Run the installer in headless mode + // The installer accepts --installClient <path> to install to a specific directory + let output = tokio::process::Command::new(java_path) + .arg("-jar") + .arg(&installer_path) + .arg("--installClient") + .arg(game_dir) + .output() + .await?; + + // Clean up installer + let _ = tokio::fs::remove_file(&installer_path).await; + + if !output.status.success() { + let stderr = String::from_utf8_lossy(&output.stderr); + let stdout = String::from_utf8_lossy(&output.stdout); + return Err(format!( + "Forge installer failed:\nstdout: {}\nstderr: {}", + stdout, stderr + ).into()); + } + + Ok(()) +} + +/// Create a Forge version JSON from the installer manifest. +fn create_forge_version_json_from_manifest( + game_version: &str, + forge_version: &str, + manifest: &ForgeInstallerManifest, +) -> Result<serde_json::Value, Box<dyn Error + Send + Sync>> { + let version_id = generate_version_id(game_version, forge_version); + + // Use main class from manifest or default + let main_class = manifest.main_class.clone().unwrap_or_else(|| { + if is_modern_forge(game_version) { + "cpw.mods.bootstraplauncher.BootstrapLauncher".to_string() + } else { + "net.minecraft.launchwrapper.Launch".to_string() + } + }); + + // Convert libraries to JSON format, preserving download info + let lib_entries: Vec<serde_json::Value> = manifest.libraries + .iter() + .map(|lib| { + let mut entry = serde_json::json!({ + "name": lib.name + }); + + // Add URL if present + if let Some(url) = &lib.url { + entry["url"] = serde_json::Value::String(url.clone()); + } else { + // Default to Forge Maven for Forge libraries + entry["url"] = serde_json::Value::String(FORGE_MAVEN_URL.to_string()); + } + + // Add downloads if present + if let Some(downloads) = &lib.downloads { + if let Some(artifact) = &downloads.artifact { + let mut artifact_json = serde_json::Map::new(); + if let Some(path) = &artifact.path { + artifact_json.insert("path".to_string(), serde_json::Value::String(path.clone())); + } + if let Some(url) = &artifact.url { + artifact_json.insert("url".to_string(), serde_json::Value::String(url.clone())); + } + if let Some(sha1) = &artifact.sha1 { + artifact_json.insert("sha1".to_string(), serde_json::Value::String(sha1.clone())); + } + if !artifact_json.is_empty() { + entry["downloads"] = serde_json::json!({ + "artifact": artifact_json + }); + } + } + } + + entry + }) + .collect(); + + // Build arguments + let mut arguments = serde_json::json!({ + "game": [], + "jvm": [] + }); + + if let Some(args) = &manifest.arguments { + if let Some(game_args) = &args.game { + arguments["game"] = serde_json::Value::Array(game_args.clone()); + } + if let Some(jvm_args) = &args.jvm { + arguments["jvm"] = serde_json::Value::Array(jvm_args.clone()); + } + } + + let json = serde_json::json!({ + "id": version_id, + "inheritsFrom": manifest.inherits_from.clone().unwrap_or_else(|| game_version.to_string()), + "type": "release", + "mainClass": main_class, + "libraries": lib_entries, + "arguments": arguments + }); + + Ok(json) +} + +/// Create a Forge version JSON with the proper library list (fallback). +#[allow(dead_code)] fn create_forge_version_json( game_version: &str, forge_version: &str, + libraries: &[ForgeLibrary], ) -> Result<serde_json::Value, Box<dyn Error + Send + Sync>> { let version_id = generate_version_id(game_version, forge_version); - let forge_maven_coord = format!( - "net.minecraftforge:forge:{}-{}", - game_version, forge_version - ); // Determine main class based on version - // Forge 1.13+ uses different launchers - let (main_class, libraries) = if is_modern_forge(game_version) { - // Modern Forge (1.13+) uses cpw.mods.bootstraplauncher - ( - "cpw.mods.bootstraplauncher.BootstrapLauncher".to_string(), - vec![ - create_library_entry(&forge_maven_coord, Some(FORGE_MAVEN_URL)), - create_library_entry( - &format!( - "net.minecraftforge:forge:{}-{}:universal", - game_version, forge_version - ), - Some(FORGE_MAVEN_URL), - ), - ], - ) + let main_class = if is_modern_forge(game_version) { + "cpw.mods.bootstraplauncher.BootstrapLauncher" } else { - // Legacy Forge uses LaunchWrapper - ( - "net.minecraft.launchwrapper.Launch".to_string(), - vec![ - create_library_entry(&forge_maven_coord, Some(FORGE_MAVEN_URL)), - create_library_entry("net.minecraft:launchwrapper:1.12", None), - ], - ) + "net.minecraft.launchwrapper.Launch" }; + // Convert libraries to JSON format + let lib_entries: Vec<serde_json::Value> = libraries + .iter() + .map(|lib| { + serde_json::json!({ + "name": lib.name, + "url": FORGE_MAVEN_URL + }) + }) + .collect(); + let json = serde_json::json!({ "id": version_id, "inheritsFrom": game_version, "type": "release", "mainClass": main_class, - "libraries": libraries, + "libraries": lib_entries, "arguments": { "game": [], "jvm": [] @@ -240,19 +441,6 @@ fn create_forge_version_json( Ok(json) } -/// Create a library entry for the version JSON. -fn create_library_entry(name: &str, maven_url: Option<&str>) -> serde_json::Value { - let mut entry = serde_json::json!({ - "name": name - }); - - if let Some(url) = maven_url { - entry["url"] = serde_json::Value::String(url.to_string()); - } - - entry -} - /// Check if the Minecraft version uses modern Forge (1.13+). fn is_modern_forge(game_version: &str) -> bool { let parts: Vec<&str> = game_version.split('.').collect(); diff --git a/src-tauri/src/main.rs b/src-tauri/src/main.rs index b69912e..3671166 100644 --- a/src-tauri/src/main.rs +++ b/src-tauri/src/main.rs @@ -121,6 +121,13 @@ async fn start_game( format!("Loading version details for {}...", version_id) ); + // First, load the local version to get the original inheritsFrom value + // (before merge clears it) + let original_inherits_from = match core::manifest::load_local_version(&game_dir, &version_id).await { + Ok(local_version) => local_version.inherits_from.clone(), + Err(_) => None, + }; + let version_details = core::manifest::load_version(&game_dir, &version_id) .await .map_err(|e| e.to_string())?; @@ -135,9 +142,7 @@ async fn start_game( // Determine the actual minecraft version for client.jar // (for modded versions, this is the parent vanilla version) - let minecraft_version = version_details - .inherits_from - .clone() + let minecraft_version = original_inherits_from .unwrap_or_else(|| version_id.clone()); // 2. Prepare download tasks @@ -380,6 +385,7 @@ async fn start_game( for lib in &version_details.libraries { if core::rules::is_library_allowed(&lib.rules) { if let Some(downloads) = &lib.downloads { + // Standard library with explicit downloads if let Some(artifact) = &downloads.artifact { let path_str = artifact .path @@ -388,6 +394,12 @@ async fn start_game( let lib_path = libraries_dir.join(path_str); classpath_entries.push(lib_path.to_string_lossy().to_string()); } + } else { + // Library without explicit downloads (mod loader libraries) + // Use Maven coordinate resolution + if let Some(lib_path) = core::maven::get_library_path(&lib.name, &libraries_dir) { + classpath_entries.push(lib_path.to_string_lossy().to_string()); + } } } } @@ -680,6 +692,300 @@ async fn get_versions() -> Result<Vec<core::manifest::Version>, String> { } } +/// Check if a version is installed (has client.jar) +#[tauri::command] +async fn check_version_installed(window: Window, version_id: String) -> Result<bool, String> { + let app_handle = window.app_handle(); + let game_dir = app_handle + .path() + .app_data_dir() + .map_err(|e| format!("Failed to get app data dir: {}", e))?; + + // For modded versions, check the parent vanilla version + let minecraft_version = if version_id.starts_with("fabric-loader-") { + // Format: fabric-loader-X.X.X-1.20.4 + version_id.split('-').last().unwrap_or(&version_id).to_string() + } else if version_id.contains("-forge-") { + // Format: 1.20.4-forge-49.0.38 + version_id.split("-forge-").next().unwrap_or(&version_id).to_string() + } else { + version_id.clone() + }; + + let client_jar = game_dir + .join("versions") + .join(&minecraft_version) + .join(format!("{}.jar", minecraft_version)); + + Ok(client_jar.exists()) +} + +/// Install a version (download client, libraries, assets) without launching +#[tauri::command] +async fn install_version( + window: Window, + config_state: State<'_, core::config::ConfigState>, + version_id: String, +) -> Result<(), String> { + emit_log!( + window, + format!("Starting installation for version: {}", version_id) + ); + + let config = config_state.config.lock().unwrap().clone(); + let app_handle = window.app_handle(); + let game_dir = app_handle + .path() + .app_data_dir() + .map_err(|e| format!("Failed to get app data dir: {}", e))?; + + // Ensure game directory exists + tokio::fs::create_dir_all(&game_dir) + .await + .map_err(|e| e.to_string())?; + + emit_log!(window, format!("Game directory: {:?}", game_dir)); + + // Load version (supports both vanilla and modded versions with inheritance) + emit_log!( + window, + format!("Loading version details for {}...", version_id) + ); + + // First, try to fetch the vanilla version from Mojang and save it locally + let version_details = match core::manifest::load_local_version(&game_dir, &version_id).await { + Ok(v) => v, + Err(_) => { + // Not found locally, fetch from Mojang + emit_log!(window, format!("Fetching version {} from Mojang...", version_id)); + let fetched = core::manifest::fetch_vanilla_version(&version_id) + .await + .map_err(|e| e.to_string())?; + + // Save the version JSON locally + emit_log!(window, format!("Saving version JSON...")); + core::manifest::save_local_version(&game_dir, &fetched) + .await + .map_err(|e| e.to_string())?; + + fetched + } + }; + + // Now load the full version with inheritance resolved + let version_details = core::manifest::load_version(&game_dir, &version_id) + .await + .map_err(|e| e.to_string())?; + + emit_log!( + window, + format!( + "Version details loaded: main class = {}", + version_details.main_class + ) + ); + + // Determine the actual minecraft version for client.jar + let minecraft_version = version_details + .inherits_from + .clone() + .unwrap_or_else(|| version_id.clone()); + + // Prepare download tasks + emit_log!(window, "Preparing download tasks...".to_string()); + let mut download_tasks = Vec::new(); + + // --- Client Jar --- + let downloads = version_details + .downloads + .as_ref() + .ok_or("Version has no downloads information")?; + let client_jar = &downloads.client; + let mut client_path = game_dir.join("versions"); + client_path.push(&minecraft_version); + client_path.push(format!("{}.jar", minecraft_version)); + + download_tasks.push(core::downloader::DownloadTask { + url: client_jar.url.clone(), + path: client_path.clone(), + sha1: client_jar.sha1.clone(), + sha256: None, + }); + + // --- Libraries --- + let libraries_dir = game_dir.join("libraries"); + + for lib in &version_details.libraries { + if core::rules::is_library_allowed(&lib.rules) { + if let Some(downloads) = &lib.downloads { + if let Some(artifact) = &downloads.artifact { + let path_str = artifact + .path + .clone() + .unwrap_or_else(|| format!("{}.jar", lib.name)); + + let mut lib_path = libraries_dir.clone(); + lib_path.push(path_str); + + download_tasks.push(core::downloader::DownloadTask { + url: artifact.url.clone(), + path: lib_path, + sha1: artifact.sha1.clone(), + sha256: None, + }); + } + + // Native Library (classifiers) + if let Some(classifiers) = &downloads.classifiers { + let os_key = if cfg!(target_os = "linux") { + "natives-linux" + } else if cfg!(target_os = "windows") { + "natives-windows" + } else if cfg!(target_os = "macos") { + "natives-osx" + } else { + "" + }; + + if let Some(native_artifact_value) = classifiers.get(os_key) { + if let Ok(native_artifact) = + serde_json::from_value::<core::game_version::DownloadArtifact>( + native_artifact_value.clone(), + ) + { + let path_str = native_artifact.path.clone().unwrap(); + let mut native_path = libraries_dir.clone(); + native_path.push(&path_str); + + download_tasks.push(core::downloader::DownloadTask { + url: native_artifact.url, + path: native_path.clone(), + sha1: native_artifact.sha1, + sha256: None, + }); + } + } + } + } else { + // Library without explicit downloads (mod loader libraries) + if let Some(url) = + core::maven::resolve_library_url(&lib.name, None, lib.url.as_deref()) + { + if let Some(lib_path) = core::maven::get_library_path(&lib.name, &libraries_dir) + { + download_tasks.push(core::downloader::DownloadTask { + url, + path: lib_path, + sha1: None, + sha256: None, + }); + } + } + } + } + } + + // --- Assets --- + let assets_dir = game_dir.join("assets"); + let objects_dir = assets_dir.join("objects"); + let indexes_dir = assets_dir.join("indexes"); + + let asset_index = version_details + .asset_index + .as_ref() + .ok_or("Version has no asset index information")?; + + let asset_index_path = indexes_dir.join(format!("{}.json", asset_index.id)); + + let asset_index_content: String = if asset_index_path.exists() { + tokio::fs::read_to_string(&asset_index_path) + .await + .map_err(|e| e.to_string())? + } else { + emit_log!(window, format!("Downloading asset index...")); + let content = reqwest::get(&asset_index.url) + .await + .map_err(|e| e.to_string())? + .text() + .await + .map_err(|e| e.to_string())?; + + tokio::fs::create_dir_all(&indexes_dir) + .await + .map_err(|e| e.to_string())?; + tokio::fs::write(&asset_index_path, &content) + .await + .map_err(|e| e.to_string())?; + content + }; + + #[derive(serde::Deserialize)] + struct AssetObject { + hash: String, + } + + #[derive(serde::Deserialize)] + struct AssetIndexJson { + objects: std::collections::HashMap<String, AssetObject>, + } + + let asset_index_parsed: AssetIndexJson = + serde_json::from_str(&asset_index_content).map_err(|e| e.to_string())?; + + emit_log!( + window, + format!("Processing {} assets...", asset_index_parsed.objects.len()) + ); + + for (_name, object) in asset_index_parsed.objects { + let hash = object.hash; + let prefix = &hash[0..2]; + let path = objects_dir.join(prefix).join(&hash); + let url = format!( + "https://resources.download.minecraft.net/{}/{}", + prefix, hash + ); + + download_tasks.push(core::downloader::DownloadTask { + url, + path, + sha1: Some(hash), + sha256: None, + }); + } + + emit_log!( + window, + format!( + "Total download tasks: {} (Client + Libraries + Assets)", + download_tasks.len() + ) + ); + + // Start Download + emit_log!( + window, + format!( + "Starting downloads with {} concurrent threads...", + config.download_threads + ) + ); + core::downloader::download_files( + window.clone(), + download_tasks, + config.download_threads as usize, + ) + .await + .map_err(|e| e.to_string())?; + + emit_log!( + window, + format!("Installation of {} completed successfully!", version_id) + ); + + Ok(()) +} + #[tauri::command] async fn login_offline( window: Window, @@ -765,24 +1071,39 @@ async fn complete_microsoft_login( ms_refresh_state: State<'_, MsRefreshTokenState>, device_code: String, ) -> Result<core::auth::Account, String> { + // Helper to emit auth progress + let emit_progress = |step: &str| { + let _ = window.emit("auth-progress", step); + }; + // 1. Poll (once) for token + emit_progress("Receiving token from Microsoft..."); let token_resp = core::auth::exchange_code_for_token(&device_code).await?; + emit_progress("Token received successfully!"); // Store MS refresh token let ms_refresh_token = token_resp.refresh_token.clone(); *ms_refresh_state.token.lock().unwrap() = ms_refresh_token.clone(); // 2. Xbox Live Auth + emit_progress("Authenticating with Xbox Live..."); let (xbl_token, uhs) = core::auth::method_xbox_live(&token_resp.access_token).await?; + emit_progress("Xbox Live authentication successful!"); // 3. XSTS Auth + emit_progress("Authenticating with XSTS..."); let xsts_token = core::auth::method_xsts(&xbl_token).await?; + emit_progress("XSTS authentication successful!"); // 4. Minecraft Auth + emit_progress("Authenticating with Minecraft..."); let mc_token = core::auth::login_minecraft(&xsts_token, &uhs).await?; + emit_progress("Minecraft authentication successful!"); // 5. Get Profile + emit_progress("Fetching Minecraft profile..."); let profile = core::auth::fetch_profile(&mc_token).await?; + emit_progress(&format!("Welcome, {}!", profile.name)); // 6. Create Account let account = core::auth::Account::Microsoft(core::auth::MicrosoftAccount { @@ -1008,6 +1329,99 @@ async fn list_installed_fabric_versions(window: Window) -> Result<Vec<String>, S .map_err(|e| e.to_string()) } +/// Installed version info +#[derive(serde::Serialize)] +struct InstalledVersion { + id: String, + #[serde(rename = "type")] + version_type: String, // "release", "snapshot", "fabric", "forge", "modpack" +} + +/// List all installed versions from the data directory +/// Simply lists all folders in the versions directory without validation +#[tauri::command] +async fn list_installed_versions(window: Window) -> Result<Vec<InstalledVersion>, String> { + let app_handle = window.app_handle(); + let game_dir = app_handle + .path() + .app_data_dir() + .map_err(|e| format!("Failed to get app data dir: {}", e))?; + + let versions_dir = game_dir.join("versions"); + let mut installed = Vec::new(); + + if !versions_dir.exists() { + return Ok(installed); + } + + let mut entries = tokio::fs::read_dir(&versions_dir) + .await + .map_err(|e| e.to_string())?; + + while let Some(entry) = entries.next_entry().await.map_err(|e| e.to_string())? { + // Only include directories + if !entry.file_type().await.map_err(|e| e.to_string())?.is_dir() { + continue; + } + + let name = entry.file_name().to_string_lossy().to_string(); + let version_dir = entry.path(); + + // Determine version type based on folder name or JSON content + let version_type = if name.starts_with("fabric-loader-") { + "fabric".to_string() + } else if name.contains("-forge") || name.contains("forge-") { + "forge".to_string() + } else { + // Try to read JSON to get type, otherwise guess from name + let json_path = version_dir.join(format!("{}.json", name)); + if json_path.exists() { + if let Ok(content) = tokio::fs::read_to_string(&json_path).await { + if let Ok(json) = serde_json::from_str::<serde_json::Value>(&content) { + json.get("type") + .and_then(|t| t.as_str()) + .unwrap_or("modpack") + .to_string() + } else { + "modpack".to_string() + } + } else { + "modpack".to_string() + } + } else { + // No JSON file - treat as modpack/custom + "modpack".to_string() + } + }; + + installed.push(InstalledVersion { + id: name, + version_type, + }); + } + + // Sort: modded/modpack first, then by version id descending + installed.sort_by(|a, b| { + let a_priority = match a.version_type.as_str() { + "fabric" | "forge" => 0, + "modpack" => 1, + _ => 2, + }; + let b_priority = match b.version_type.as_str() { + "fabric" | "forge" => 0, + "modpack" => 1, + _ => 2, + }; + + match a_priority.cmp(&b_priority) { + std::cmp::Ordering::Equal => b.id.cmp(&a.id), // Descending order + other => other, + } + }); + + Ok(installed) +} + /// Check if Fabric is installed for a specific version #[tauri::command] async fn is_fabric_installed( @@ -1050,6 +1464,7 @@ async fn get_forge_versions_for_game( #[tauri::command] async fn install_forge( window: Window, + config_state: State<'_, core::config::ConfigState>, game_version: String, forge_version: String, ) -> Result<core::forge::InstalledForgeVersion, String> { @@ -1067,6 +1482,31 @@ async fn install_forge( .app_data_dir() .map_err(|e| format!("Failed to get app data dir: {}", e))?; + // Get Java path from config or detect + let config = config_state.config.lock().unwrap().clone(); + let java_path_str = if !config.java_path.is_empty() && config.java_path != "java" { + config.java_path.clone() + } else { + // Try to find a suitable Java installation + let javas = core::java::detect_all_java_installations(&app_handle); + if let Some(java) = javas.first() { + java.path.clone() + } else { + return Err("No Java installation found. Please configure Java in settings.".to_string()); + } + }; + let java_path = std::path::PathBuf::from(&java_path_str); + + emit_log!(window, "Running Forge installer...".to_string()); + + // Run the Forge installer to properly patch the client + core::forge::run_forge_installer(&game_dir, &game_version, &forge_version, &java_path) + .await + .map_err(|e| format!("Forge installer failed: {}", e))?; + + emit_log!(window, "Forge installer completed, creating version profile...".to_string()); + + // Now create the version JSON let result = core::forge::install_forge(&game_dir, &game_version, &forge_version) .await .map_err(|e| e.to_string())?; @@ -1241,6 +1681,9 @@ fn main() { .invoke_handler(tauri::generate_handler![ start_game, get_versions, + check_version_installed, + install_version, + list_installed_versions, login_offline, get_active_account, logout, |