| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | fix(path): resolve critical java path validation bug on unix |   Begonia, HE | 2026-01-16 | 1 | -11/+149 |
| | | | | | | | | | | | | | | | | | | | | | Fix a critical bug in normalize_java_path where Unix implementation would return Ok(non-existent path) when java_path == "java" and the `which` command failed to find Java in PATH. This caused game launch failures with confusing error messages. Key changes: - Add strip_unc_prefix helper for Windows UNC path handling - Fix Unix bug: explicitly return error when PATH search fails - Apply canonicalize + strip_unc_prefix pattern to both platforms - Enhanced error messages distinguishing PATH vs specific path failures - Add comprehensive unit tests covering edge cases - Update documentation to reflect actual behavior Resolves issue where Windows and Unix users could not launch games when Java path resolution failed silently. Reviewed-by: Claude Sonnet 4.5 | ||||
| * | fix(windows): resolve Java executable path issues on Windows | Begonia, HE | 2026-01-16 | 1 | -0/+105 |
| - Add normalize_java_path utility function with Windows-specific handling - Automatically append .exe extension when missing on Windows - Use 'where' command to locate java.exe in PATH if not found - Improve error messages with full path display for debugging - Apply path normalization in both start_game and install_forge commands This fixes the "Failed to launch java: program not found" error on Windows by properly handling Java executable paths, including relative paths, missing extensions, and PATH resolution. Reviewed-by: Claude Sonnet 4.5 | |||||