diff options
| author |   Renaud G <renaud@rolisteam.org> | 2019-01-05 18:17:17 +0100 |
|---|---|---|
| committer | Renaud G <renaud@rolisteam.org> | 2019-01-05 18:17:17 +0100 |
| commit | 0fcbfc01baf4dc8fc42fe9a40033be14808c2c7f (patch) | |
| tree | aa3eac1c1d87d49d133a28916d0c49b901af5578 /result | |
| parent | 0ead8d42d93ee5d91519f006a84a942109bf4f36 (diff) | |
| download | OneRoll-0fcbfc01baf4dc8fc42fe9a40033be14808c2c7f.tar.gz OneRoll-0fcbfc01baf4dc8fc42fe9a40033be14808c2c7f.zip | |
clazy warnings
Diffstat (limited to 'result')
| -rw-r--r-- | result/diceresult.cpp | 8 | ||||
| -rw-r--r-- | result/stringresult.cpp | 2 |
2 files changed, 5 insertions, 5 deletions
diff --git a/result/diceresult.cpp b/result/diceresult.cpp index c1089dd..9f6f913 100644 --- a/result/diceresult.cpp +++ b/result/diceresult.cpp @@ -80,7 +80,7 @@ QVariant DiceResult::getResult(RESULT_TYPE type) } bool DiceResult::contains(Die* die, const std::function<bool(const Die*,const Die*)> equal) { - for(auto value : m_diceValues) + for(auto& value : m_diceValues) { if(equal(value,die)) { @@ -99,7 +99,7 @@ qreal DiceResult::getScalarResult() { qint64 scalar=0; int i = 0; - for(auto tmp : m_diceValues) + for(auto& tmp : m_diceValues) { if(i>0) { @@ -157,13 +157,13 @@ void DiceResult::setOperator(const Die::ArithmeticOperator& dieOperator) QString DiceResult::toString(bool wl) { QStringList scalarSum; - for(auto die : m_diceValues) + for(auto& die : m_diceValues) { scalarSum << QString::number(die->getValue()); } if(wl) { - return QStringLiteral("%3 [label=\"DiceResult Value %1 dice %2\"]").arg(getScalarResult()).arg(scalarSum.join('_')).arg(m_id); + return QStringLiteral("%3 [label=\"DiceResult Value %1 dice %2\"]").arg(QString::number(getScalarResult()), scalarSum.join('_'), m_id); } else { diff --git a/result/stringresult.cpp b/result/stringresult.cpp index f0ff699..2858155 100644 --- a/result/stringresult.cpp +++ b/result/stringresult.cpp @@ -51,7 +51,7 @@ QString StringResult::toString(bool wl) { if(wl) { - return QString("%2 [label=\"StringResult_value_%1\"]").arg(getText().replace("%","_")).arg(m_id); + return QString("%2 [label=\"StringResult_value_%1\"]").arg(getText().replace("%","_"), m_id); } else { |