From 210d249da7ffe4e9cc570e3bc0f429c41a8e8dac Mon Sep 17 00:00:00 2001 From: Renaud G Date: Thu, 14 May 2015 10:18:23 +0200 Subject: -fix crash with K operator. --- diceparser.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/diceparser.cpp b/diceparser.cpp index 1046ade..e533b7e 100644 --- a/diceparser.cpp +++ b/diceparser.cpp @@ -762,8 +762,11 @@ bool DiceParser::readOption(QString& str,ExecutionNode* previous, bool hasDice)/ previous = addRollDiceNode(DEFAULT_FACES_NUMBER,previous); } DiceRollerNode* nodeTmp = dynamic_cast(previous); + if(NULL!=nodeTmp) + { - previous = addExploseDiceNode(nodeTmp->getFaces(),previous); + previous = addExploseDiceNode(nodeTmp->getFaces(),previous); + } node = m_parsingToolbox->addSort(previous,ascending); -- cgit v1.2.3-70-g09d2 From 734ef32d7969d9d5e05a3013eeeef956d12fc603 Mon Sep 17 00:00:00 2001 From: Renaud G Date: Sat, 16 May 2015 08:58:09 +0200 Subject: fix the removal of color --- cli/main.cpp | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/cli/main.cpp b/cli/main.cpp index f6197ce..9a966ba 100644 --- a/cli/main.cpp +++ b/cli/main.cpp @@ -43,7 +43,7 @@ QTextStream out(stdout, QIODevice::WriteOnly); -QString diceToText(ExportedDiceResult& dice) +QString diceToText(ExportedDiceResult& dice,bool highlight) { QStringList resultGlobal; foreach(int face, dice.keys()) @@ -62,10 +62,9 @@ QString diceToText(ExportedDiceResult& dice) qint64 dievalue = tmp.first[i]; QString prefix("%1"); - if(tmp.second) + if((tmp.second)&&(highlight)) { prefix = "\e[0;31m%1\e[0m"; - } if(i==0) @@ -116,7 +115,7 @@ void startDiceParsing(QString& cmd,QString& treeFile,bool highlight) ExportedDiceResult list; parser->getLastDiceResult(list); - QString diceText = diceToText(list); + QString diceText = diceToText(list,highlight); QString scalarText; QString str; @@ -128,8 +127,10 @@ void startDiceParsing(QString& cmd,QString& treeFile,bool highlight) { scalarText = QString("%1").arg(parser->getSumOfDiceResult()); } - - str = QString("Result: \e[0;31m%1\e[0m, details:[%3 (%2)]").arg(scalarText).arg(diceText).arg(parser->getDiceCommand()); + if(highlight) + str = QString("Result: \e[0;31m%1\e[0m, details:[%3 (%2)]").arg(scalarText).arg(diceText).arg(parser->getDiceCommand()); + else + str = QString("Result: %1, details:[%3 (%2)]").arg(scalarText).arg(diceText).arg(parser->getDiceCommand()); if(parser->hasStringResult()) { -- cgit v1.2.3-70-g09d2 From a642432bfdaafe4fccf1defeb0aa79a6db7467c3 Mon Sep 17 00:00:00 2001 From: Renaud G Date: Sat, 16 May 2015 08:58:51 +0200 Subject: remove useless debug outputs --- diceparser.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/diceparser.cpp b/diceparser.cpp index c7383da..f8f82d6 100644 --- a/diceparser.cpp +++ b/diceparser.cpp @@ -542,7 +542,6 @@ bool DiceParser::readDice(QString& str,ExecutionNode* & node) { int face = abs(num - end)+1; - qDebug()<< num << end<< face; DiceRollerNode* drNode = new DiceRollerNode(face,num); node = drNode; ExecutionNode* current = drNode; -- cgit v1.2.3-70-g09d2 From 2f24c7b8361d87b67e0a204b1f054d750f650d66 Mon Sep 17 00:00:00 2001 From: Renaud G Date: Sat, 16 May 2015 08:59:06 +0200 Subject: remove useless debug outputs --- parsingtoolbox.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/parsingtoolbox.cpp b/parsingtoolbox.cpp index 0052f07..f6b1f12 100644 --- a/parsingtoolbox.cpp +++ b/parsingtoolbox.cpp @@ -238,16 +238,13 @@ bool ParsingToolBox::readDiceRange(QString& str,int& start, int& end) { bool expectSquareBrasket=false; - qDebug()<<"readDiceRange"<