From adf9031cf7ddf06d8806a2b8e4494984a21608b5 Mon Sep 17 00:00:00 2001
From: Renaud G <renaud@rolisteam.org>
Date: Wed, 25 Dec 2019 02:59:27 +0100
Subject: Improve perf

---
 cli/displaytoolbox.cpp | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

(limited to 'cli')

diff --git a/cli/displaytoolbox.cpp b/cli/displaytoolbox.cpp
index fc2c7ed..9dc8fb6 100644
--- a/cli/displaytoolbox.cpp
+++ b/cli/displaytoolbox.cpp
@@ -121,6 +121,7 @@ QString DisplayToolBox::diceToSvg(QJsonArray array, bool withColor, bool allSame
         return result.join("");
     }
 }
+#include <QVariantList>
 QJsonArray DisplayToolBox::diceToJson(QList<ExportedDiceResult>& diceList, bool& allSameFaceCount, bool& allSameColor)
 {
     allSameFaceCount= true;
@@ -137,8 +138,9 @@ QJsonArray DisplayToolBox::diceToJson(QList<ExportedDiceResult>& diceList, bool&
         {
             ListDiceResult diceResults= dice.value(face);
             QJsonObject object;
-            QJsonArray values;
+            QVariantList listVariant;
             object["face"]= static_cast<int>(face);
+            listVariant.reserve(diceResults.size());
             for(auto const& dice : diceResults)
             {
                 QJsonObject diceObj;
@@ -158,9 +160,9 @@ QJsonArray DisplayToolBox::diceToJson(QList<ExportedDiceResult>& diceList, bool&
                     }
                     diceObj["subvalues"]= subValues;
                 }
-                values.push_back(diceObj);
+                listVariant.append(QVariant::fromValue(diceObj));
             }
-            object["values"]= values;
+            object["values"]= QJsonArray::fromVariantList(listVariant);
             array.push_back(object);
         }
     }
-- 
cgit v1.2.3-70-g09d2