From 0fcbfc01baf4dc8fc42fe9a40033be14808c2c7f Mon Sep 17 00:00:00 2001 From: Renaud G Date: Sat, 5 Jan 2019 18:17:17 +0100 Subject: clazy warnings --- result/diceresult.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'result/diceresult.cpp') diff --git a/result/diceresult.cpp b/result/diceresult.cpp index c1089dd..9f6f913 100644 --- a/result/diceresult.cpp +++ b/result/diceresult.cpp @@ -80,7 +80,7 @@ QVariant DiceResult::getResult(RESULT_TYPE type) } bool DiceResult::contains(Die* die, const std::function equal) { - for(auto value : m_diceValues) + for(auto& value : m_diceValues) { if(equal(value,die)) { @@ -99,7 +99,7 @@ qreal DiceResult::getScalarResult() { qint64 scalar=0; int i = 0; - for(auto tmp : m_diceValues) + for(auto& tmp : m_diceValues) { if(i>0) { @@ -157,13 +157,13 @@ void DiceResult::setOperator(const Die::ArithmeticOperator& dieOperator) QString DiceResult::toString(bool wl) { QStringList scalarSum; - for(auto die : m_diceValues) + for(auto& die : m_diceValues) { scalarSum << QString::number(die->getValue()); } if(wl) { - return QStringLiteral("%3 [label=\"DiceResult Value %1 dice %2\"]").arg(getScalarResult()).arg(scalarSum.join('_')).arg(m_id); + return QStringLiteral("%3 [label=\"DiceResult Value %1 dice %2\"]").arg(QString::number(getScalarResult()), scalarSum.join('_'), m_id); } else { -- cgit v1.2.3-70-g09d2